This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Print entirely unavailable struct/union values as a single <unavailable>. (Re: [PATCH 06/12] Delete value_bits_valid.)
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: "Pedro Alves" <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 26 Nov 2013 09:39:17 +0000
- Subject: Re: [PATCH] Print entirely unavailable struct/union values as a single <unavailable>. (Re: [PATCH 06/12] Delete value_bits_valid.)
- Authentication-results: sourceware.org; auth=none
- References: <5208D1DF dot 1090201 at broadcom dot com> <5208D495 dot 9080806 at broadcom dot com> <52939BD4 dot 4090803 at redhat dot com>
On 25/11/2013 6:49 PM, Pedro Alves wrote:
>
> I'd like to get this part out of the way; I don't have a problem with
> it.
>
> We don't really need the whole series for this though. Any
> objections?
Sounds reasonable to me.
> gdb/
> 2013-11-25 Andrew Burgess <aburgess@broadcom.com>
> Pedro Alves <palves@redhat.com>
>
> * valprint.c (value_check_printable): If the value is entirely
> unavailable, print a single "<unavailable>" instead of printing
> all subfields.
>
> gdb/testsuite/
> 2013-11-25 Andrew Burgess <aburgess@broadcom.com>
>
> * gdb.trace/unavailable.exp(gdb_collect_args_test): Update
> expected results.
> (gdb_collect_locals_test): Likewise.
> (gdb_collect_globals_test): Likewise.
Looks fine to me.
Thanks,
Andrew