Re: [patch, nios2] Update Linux parts for new syscall ABI

[Chung-Lin Tang <cltang at codesourcery dot com>]

On 13/12/2 11:23 AM, Joel Brobecker wrote:
>> This patch updates the nios2-linux code for the new Linux generic system
>> call interface. Mainly removing (non-rt) sigreturn related definitions,
>> and updating the rt_sigreturn syscall NR.
>>
>> Will commit after Sandra's approval.
> 
> I am sorry to be so procedural, but while Sandra input would probably
> be more valuable than most, Sandra is not yet listed as maintainer
> in GDB. She can therefore not approve patches for commit in the official
> repository yet. It should all be documented in gdb/MAINTAINERS.

Is Sandra not nios2 maintainer, or is she just not yet added to the
MAINTAINERS file?

>> 2013-12-01  Chung-Lin Tang  <cltang@codesourcery.com>
>>
>>         gdb/
>>         * nios2-linux-tdep.c (nios2_linux_sigreturn_init): Remove.
>>         (nios2_linux_sigreturn_tramp_frame): Remove.
>>         (nios2_linux_rt_sigreturn_tramp_frame): Update rt_sigreturn syscall
>>         number.
>>         (nios2_linux_syscall_next_pc): Likewise. Remove sigreturn case.
>>         (nios2_linux_init_abi):
>>         Remove registration of nios2_linux_sigreturn_tramp_frame.
> 
> My concern with your patch is that it seems to eliminate support for
> the previous syscall ABI, which means a break in compatibility. Unless
> we really have no other choice, I don't think we would want that.

This is a coordinated change, Altera will be using the new syscall ABI
when they upstream the kernel port.

Thanks,
Chung-Lin