This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Allow Windows UNWIND_INFO version 2.
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 03 Dec 2013 18:47:41 +0000
- Subject: Re: [RFA] Allow Windows UNWIND_INFO version 2.
- Authentication-results: sourceware.org; auth=none
- References: <1386070345-8237-1-git-send-email-brobecker at adacore dot com>
On 12/03/2013 11:32 AM, Joel Brobecker wrote:
> @@ -696,7 +697,17 @@ amd64_windows_frame_decode_insns (struct frame_info *this_frame,
> return;
>
> end_insns = &insns[codes_count * 2];
> - for (p = insns; p < end_insns; p += 2)
> + p = insns;
> +
> + /* Skip opcodes 6 of version 2. This opcode is not documented. */
> + if (PEX64_UWI_VERSION (ex_ui.Version_Flags) == 2)
> + {
> + for (; p < end_insns; p += 2)
> + if (PEX64_UNWCODE_CODE (p[1]) != 6)
> + break;
> + }
I'd consider merging with the existing loop, so that
we print the opcodes when frame debug is enabled.
But anyway, this looks fine to me.
I clicked on "Did you find this helpful? No" at:
http://msdn.microsoft.com/en-us/library/ck9asaa9.aspx
and asked for info about v2 and opcode 6. Not holding
my breath though.
--
Pedro Alves