This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Allow Windows UNWIND_INFO version 2.
- From: Tristan Gingold <gingold at adacore dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, "<gdb-patches at sourceware dot org> ml" <gdb-patches at sourceware dot org>
- Date: Wed, 4 Dec 2013 09:43:36 +0100
- Subject: Re: [RFA] Allow Windows UNWIND_INFO version 2.
- Authentication-results: sourceware.org; auth=none
- References: <1386070345-8237-1-git-send-email-brobecker at adacore dot com> <529E274D dot 607 at redhat dot com>
On 03 Dec 2013, at 19:47, Pedro Alves <palves@redhat.com> wrote:
> On 12/03/2013 11:32 AM, Joel Brobecker wrote:
>> @@ -696,7 +697,17 @@ amd64_windows_frame_decode_insns (struct frame_info *this_frame,
>> return;
>>
>> end_insns = &insns[codes_count * 2];
>> - for (p = insns; p < end_insns; p += 2)
>> + p = insns;
>> +
>> + /* Skip opcodes 6 of version 2. This opcode is not documented. */
>> + if (PEX64_UWI_VERSION (ex_ui.Version_Flags) == 2)
>> + {
>> + for (; p < end_insns; p += 2)
>> + if (PEX64_UNWCODE_CODE (p[1]) != 6)
>> + break;
>> + }
>
> I'd consider merging with the existing loop, so that
> we print the opcodes when frame debug is enabled.
Not sure this is a good idea. You can use objdump -p if you want to view the opcodes.
But this opcode was also used in version 1, and in version 2 appears only before all other
opcodes.
Tristan.