This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Date: Wed, 04 Dec 2013 21:33:04 -0200
- Subject: Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
- Authentication-results: sourceware.org; auth=none
- References: <1385336092-19621-1-git-send-email-sergiodj at redhat dot com> <87wqjt222h dot fsf at fleche dot redhat dot com>
On Wednesday, November 27 2013, Tom Tromey wrote:
> FWIW in this specific case I think this testing approach is ok.
> The patch pretty clearly just touches the stap probe code.
> Could you say, though, exactly which tests you ran?
Thanks. For this case, I ran manually the tests from
gdb.base/stap-probe.exp, checking the results and making sure everything
is working OK.
Since the AArch64 asm permits more than one numeric literal prefix to be
used, I hacked the generated assembly in order to test this too. Soon I
will post a patch that extends the current generic parser to accept
multiple prefixes/suffixes, and then I will repost this AArch64 support
patch on top of it.
--
Sergio