Re: [PATCH 4/4] tracepoint multithread and multiprocess support (doc)

[Hui Zhu <hui_zhu at mentor dot com>]

On 12/05/13 01:39, Eli Zaretskii wrote:
> > Date: Thu, 5 Dec 2013 00:16:40 +0800
> > From: Hui Zhu <hui_zhu@mentor.com>
> >
> > This patch is for the doc.
>
> Thanks.
>
> > +@item MultiProcessTracepoint
> > +@cindex string tracing, in remote protocol
> > +The remote stub supports create a new tracepoint with multiprocess
>
>    The remote stub supports creation of tracepoints with multiprocess
>
> > +See @ref{Tracepoint Packets} for details about create a new tracepoint.
>     ^^^^^^^^
> Just "@xref" is enough.
>
> OK with those changes.

Make a new patch according to your comments.

Thanks,
Hui

2013-12-05  Hui Zhu  <hui@codesourcery.com>

	* gdb.texinfo (General Query Packets): Mention
	MultiProcessTracepoint feature.
	(QTDP): Add 'P'.

--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -39598,6 +39598,11 @@ These are the currently defined stub fea
 @tab @samp{-}
 @tab No
 
+@item @samp{MultiProcessTracepoint}
+@tab No
+@tab @samp{-}
+@tab No
+
 @end multitable
 
 These are the currently defined stub features, in more detail:
@@ -39771,6 +39776,12 @@ The remote stub understands the @samp{Qb
 @item Qbtrace:bts
 The remote stub understands the @samp{Qbtrace:bts} packet.
 
+@item MultiProcessTracepoint
+@cindex string tracing, in remote protocol
+The remote stub supports creation of tracepoints with multiprocess
+and multithread infomation.
+@xref{Tracepoint Packets}.
+
 @end table
 
 @item qSymbol::
@@ -40298,7 +40309,7 @@ tracepoints (@pxref{Tracepoints}).
 
 @table @samp
 
-@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:X@var{len},@var{bytes}]@r{[}-@r{]}
+@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:P@var{thread-id}][:X@var{len},@var{bytes}]@r{[}-@r{]}
 @cindex @samp{QTDP} packet
 Create a new tracepoint, number @var{n}, at @var{addr}.  If @var{ena}
 is @samp{E}, then the tracepoint is enabled; if it is @samp{D}, then
@@ -40306,7 +40317,10 @@ the tracepoint is disabled.  @var{step}
 count, and @var{pass} is its pass count.  If an @samp{F} is present,
 then the tracepoint is to be a fast tracepoint, and the @var{flen} is
 the number of bytes that the target should copy elsewhere to make room
-for the tracepoint.  If an @samp{X} is present, it introduces a
+for the tracepoint.  If a @samp{P} is present, the thread designator
+@var{thread-id} that has the format and interpretation described in
+@ref{thread-id syntax} includes the multiprocess and multithread infomation
+of this tracepoint.  If an @samp{X} is present, it introduces a
 tracepoint condition, which consists of a hexadecimal length, followed
 by a comma and hex-encoded bytes, in a manner similar to action
 encodings as described below.  If the trailing @samp{-} is present,