This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH [0/2] Convert unavailable vector to be bit, not byte, based.
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 05 Dec 2013 16:17:55 +0000
- Subject: Re: PATCH [0/2] Convert unavailable vector to be bit, not byte, based.
- Authentication-results: sourceware.org; auth=none
- References: <529F489F dot 7070805 at broadcom dot com>
On 12/04/2013 03:22 PM, Andrew Burgess wrote:
> This patch set is inspired by two previous patches I've posted:
>
> https://sourceware.org/ml/gdb-patches/2013-08/msg00305.html
> https://sourceware.org/ml/gdb-patches/2013-08/msg00309.html
>
> but I think can exist as a separate piece of work.
Excellent! The new test is quite nice work.
> The vector of unavailable parts of a value is currently byte based.
> Given that we can model a value down to the bit level, we can
> potentially loose information with the current implementation. After
> the patch we model the unavailable information in bits.
It'd be good if this paragraph ended up in the commit log of patch 2.
>
> Tested on x86-64 linux, including against native gdbserver.
This too.
>
> Thanks,
> Andrew
--
Pedro Alves