Re: [PATCH 00/13] script language API for GDB

[Doug Evans <xdje42 at gmail dot com>]

Phil Muldoon <pmuldoon@redhat.com> writes:
> On 06/12/13 05:51, Doug Evans wrote:
>> Ok, let's try this again.
>> 
>> On Thu, Dec 5, 2013 at 9:05 AM, Doug Evans <xdje42@gmail.com> wrote:
>>> Hi.
>>>
>>> My patch set to add a scripting API to GDB is ready for submission.
>>> It sets things up so that adding Guile scripting is straightforward.
>>> I've cc'd guile-users to apprise them of my progress.
>>> I'll spare them the actual set of patches here,
>>> though I plan to cc them when submitting the Guile port,
>>> their input will be helpful.
>>> The actual Guile port is ready ... just have some more docs to write. :-)
>
> Thanks I reviewed the series.  Most comments are inline.  I will do a summary here.
>
> More documentation.  The API implementer really needs to know about
> what they have to really implement over what is optional.  An addition
> to the internals manual would be super. At the very least far more
> comments in the structures.

Righto.
My plan is to augment the internals manual in time.

> Scripting language priority needs to be looked at in certain
> situations.

Indeed.  My intention is that in cases where it matters
the first one wins, and python will stay first in the list.

> I documented my thoughts in-line. But as I presume each
> scripting language keeps its own meta-data, (IE printer lists), we
> will have to refactor the "info
> frame-filter/type-printer/pretty-printer" commands to work with all of
> them.

One thought I have for this is "info guile pretty-printer", etc.
That simplifies a lot of things.
>From a u/i perspective it has both plusses and minuses, but I like it overall.

> Internal naming nits.
>
> A few comments on some breakpoint struct changes.
>
> Cheers,
>
> Phil