This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet


On Sat, Dec 7, 2013 at 9:13 PM, Hui Zhu <hui_zhu@mentor.com> wrote:
> 2013-12-08  Hui Zhu  <hui@codesourcery.com>
>
>         PR gdb/16101
>         * breakpoint.c (insert_bp_location): Change hw_bp_err_string to
>         bp_err_string.
>
>         Output error message of software breakpoints.
>         Make solib error message output use same code with hardware
>         breakpoints and software breakpoints.
>
>         * remote.c (remote_insert_breakpoint): If this breakpoint has
>         target-side commands but this stub doesn't support Z0 packets,
>         throw error.

Nit.  This changelog is badly formatted.
Please fix.

I suspect, though this is only based on perusal of the patch,
and not close analysis,  that you meant to write:

        PR gdb/16101
        * breakpoint.c (insert_bp_location): Change hw_bp_err_string to
        bp_err_string.  Output error message of software breakpoints.
        Make solib error message output use same code with hardware
        breakpoints and software breakpoints.

         * remote.c (remote_insert_breakpoint): If this breakpoint has
         target-side commands but this stub doesn't support Z0 packets,
         throw error.

[I may have gotten the indentation wrong, cut-n-paste in gmail, blech.
The point is the blank line before "Output error ..." is wrong.  ISTM.]


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]