This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Delete interp_exec_p
- From: Doug Evans <dje at google dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 10 Dec 2013 16:09:23 -0800
- Subject: Re: [PATCH] Delete interp_exec_p
- Authentication-results: sourceware.org; auth=none
- References: <yjt2mwl9rwa6 dot fsf at ruffy dot mtv dot corp dot google dot com> <52836108 dot 7090105 at redhat dot com>
Pedro Alves writes:
> [...]
> I considered whether it would be a cleaner to not install
> a exec_proc hook. But I think it'd be just as good to
> have gdbtk_interpreter_exec itself return the error
> instead of returning exception_none.
>
> > Regression tested on amd64-linux.
> >
> > Ok to check in?
> >
> > 2013-11-12 Doug Evans <dje@google.com>
> >
> > * interps.h (interp_exec_p): Delete.
> > * interps.c (interp_exec_p): Delete.
> > (interp_exec): Update. Assert interp->procs->exec_proc != NULL.
> > * mi/mi-interp.c (mi_cmd_interpreter_exec): Update.
>
> Looks good to me.
Thanks.
Committed.