This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add target_xfer_partial_ftype


> > This patch adds a typedef target_xfer_partial_ftype.  When we change
> > the signature of xfer_partial functions (for example, adding a new
> > parameter), we don't have to modify all of their declarations.
> > 
> > This patch also updates the type of parameters of target_xfer_partial
> > from "void *" to "gdb_byte *".
> > 
> > It is obvious to me, but comments are still welcome.
> > 
> 
> Thanks, looks good to me.

And FWIW, I really like it when we're using function types. These
types are also a good anchor for documenting their intended behavior.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]