This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v9 12/29] record-btrace: make ranges include begin and end
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: jan dot kratochvil at redhat dot com, palves at redhat dot com, gdb-patches at sourceware dot org
- Date: Thu, 19 Dec 2013 19:30:11 +0200
- Subject: Re: [PATCH v9 12/29] record-btrace: make ranges include begin and end
- Authentication-results: sourceware.org; auth=none
- References: <1387471499-29444-1-git-send-email-markus dot t dot metzger at intel dot com> <1387471499-29444-13-git-send-email-markus dot t dot metzger at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 19 Dec 2013 17:44:42 +0100
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -45,6 +45,9 @@
> The instruction range is now prefixed with 'insn'.
> The source line range is now prefixed with 'at'.
>
> +* The ranges given as arguments to the 'record function-call-history' and
> + 'record instruction-history' commands are now inclusive.
This part is OK.
> @item record instruction-history @var{begin} @var{end}
> Disassembles instructions beginning with instruction number
> -@var{begin} until instruction number @var{end}. The instruction
> -number @var{end} is not included.
> +@var{begin} until instruction number @var{end}.
> @end table
The previous text explicitly said the range was not inclusive, so I
suggest that we now say it _is_ inclusive. I always ask myself this
question when I read similar descriptions that don't spell that out.
> @item record function-call-history @var{begin} @var{end}
> Prints functions beginning with function number @var{begin} until
> -function number @var{end}. The function number @var{end} is not
> -included.
> +function number @var{end}.
Same here.
The documentation parts are OK with these changes.
Thanks.