This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v9 21/29] record-btrace: provide xfer_partial target method
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: jan dot kratochvil at redhat dot com, gdb-patches at sourceware dot org
- Date: Thu, 19 Dec 2013 19:26:49 +0000
- Subject: Re: [PATCH v9 21/29] record-btrace: provide xfer_partial target method
- Authentication-results: sourceware.org; auth=none
- References: <1387471499-29444-1-git-send-email-markus dot t dot metzger at intel dot com> <1387471499-29444-22-git-send-email-markus dot t dot metzger at intel dot com>
On 12/19/2013 04:44 PM, Markus Metzger wrote:
Also,
> + /* Filter out requests that don't make sense during replay. */
> + if (!record_btrace_allow_memory_access && record_btrace_is_replaying ())
> + {
> + switch (object)
> + {
> + case TARGET_OBJECT_MEMORY:
> + case TARGET_OBJECT_RAW_MEMORY:
> + case TARGET_OBJECT_STACK_MEMORY:
> + {
I don't think you answered my comment about this in the previous
series. I think you can't ever see TARGET_OBJECT_RAW_MEMORY or
TARGET_OBJECT_STACK_MEMORY here.
--
Pedro Alves