This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch] Use "<unknown>" instead of NULL when a symbol isn't found
- From: Sterling Augustine <saugustine at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Keith Seitz <keiths at redhat dot com>
- Date: Mon, 23 Dec 2013 15:17:19 -0800
- Subject: Re: [Patch] Use "<unknown>" instead of NULL when a symbol isn't found
- Authentication-results: sourceware.org; auth=none
- References: <CAEG7qUxE2eiqv0nGe6=UJ9NpsgCAf0WtG2VPtiJpczaWatxwmg at mail dot gmail dot com> <87haa3ie0r dot fsf at fleche dot redhat dot com>
On Fri, Dec 20, 2013 at 10:16 AM, Tom Tromey <tromey@redhat.com> wrote:
> I wonder whether some correction or workaround is required elsewhere.
There are various parts of linepec.c that assume that this field is
never null, either by assertion or by dereferencing it. Any other
workaround (at least for the case I'm dealing with) would probably
just print an error message.
>
> Sterling> The following patch simply assigns the symbol name as "<unknown>"
> Sterling> instead of NULL, allowing the debugger to make forward progress in the
> Sterling> face of an erroneous debug line table entry.
>
> You didn't say whether you regression-tested this; but assuming so, it
> is ok.
I did run regressions and it didn't introduce any new ones.
Thanks. Committed as posted.