This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add d_main_name to dlang.c
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Iain Buclaw <ibuclaw at gdcproject dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 7 Jan 2014 14:44:23 +0400
- Subject: Re: [PATCH] Add d_main_name to dlang.c
- Authentication-results: sourceware.org; auth=none
- References: <CABOHX+fBVoYBcaUS95pT-19jeuWiN21SiWWGUC5Y6O-A-3Pj_g at mail dot gmail dot com> <87mwl0mlsa dot fsf at fleche dot redhat dot com> <CABOHX+f2y2J3RFScZ2AjLgmamO4DEdzErW4B8ZbjiUYMWQkAfA at mail dot gmail dot com> <874n78mge2 dot fsf at fleche dot redhat dot com> <39451 dot 43601527$1384894769 at news dot gmane dot org> <87bo1gksu3 dot fsf at fleche dot redhat dot com> <CABOHX+eCMf9_++hn7pkXnD4ta35m-yOR=gAeRexPVtA-A00nTg at mail dot gmail dot com> <CABOHX+dV-AQ4SEwywv=OU2Wit62yYLz9BKMs4KcqBT=JNYGdtQ at mail dot gmail dot com>
> By the way, would it be best to split this up into smaller changes?
If they can and should be applied independently, most definitely.
This has two strong advantages I can think of:
- In case problem requiring a revert (I am not speaking of your
patch!), it allows us to revert the one patch that causes problem,
while keepping the rest;
- It makes it much easier to review the patches, first because
they are easier to digest, and second because we can review
them one at a time, making it more likely for us to find the time
to do so.
--
Joel