This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Change to_xfer_partial 'len' type to ULONGEST.
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 8 Jan 2014 23:30:13 +0800
- Subject: Re: [PATCH 2/4] Change to_xfer_partial 'len' type to ULONGEST.
- Authentication-results: sourceware.org; auth=none
- References: <1389166060-434-1-git-send-email-yao at codesourcery dot com> <1389166060-434-3-git-send-email-yao at codesourcery dot com> <52CD45C2 dot 8050507 at redhat dot com>
On 01/08/2014 08:34 PM, Pedro Alves wrote:
> Is this a bug fix (if so, it should go is separately)?
>
It is not a bug fix, just make sure 'len' can't be negative when we
change it unsigned type.
> But, AFAICS, we have:
>
> if (block > len)
> block = len;
>
> above, so it shouldn't be necessary.
Right, this chunk of change is unnecessary. I'll remove it from the
patch.
--
Yao (éå)