This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix check for ICC incomplete struct types
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Eager <eager at eagerm dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 08 Jan 2014 09:38:24 -0700
- Subject: Re: [PATCH] Fix check for ICC incomplete struct types
- Authentication-results: sourceware.org; auth=none
- References: <52CC3790 dot 4030702 at eagerm dot com> <87bnznhbtn dot fsf at fleche dot redhat dot com> <52CC60B7 dot 60004 at eagerm dot com>
>>>>> "Michael" == Michael Eager <eager@eagerm.com> writes:
Michael> TYPE_IS_OPAQUE does honor TYPE_STUB and checks it before
Michael> TYPE_STUB_SUPPORTED. Which is absolutely screwy, since
Michael> TYPE_STUB_SUPPORTED is set for all non-ICC producers.
Right you are.
I think TYPE_STUB_SUPPORTED is there to handle just the case where
TYPE_STUB is zero. I guess the older symbol readers didn't set
TYPE_STUB, so this hack was introduced. If TYPE_STUB is set, then it's
safe to assume that the symbol reader knew what it was doing.
Michael> I'm happy to remove it and all the associated dreck and
Michael> reorder the test as you suggest.
I think my variant is mildly better because it consolidates all the
TYPE_STUB bits into a single paragraph. If you agree, please go ahead.
Tom