This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/7] Fix for memory record corruption due to 64bit addresses


On 01/07/2014 12:50 AM, Pedro Alves wrote:
> On 01/03/2014 07:15 PM, Omair Javaid wrote:
>> This patch changes record memory address type to unsigned 32bit integers.
>> On targets where CORE_ADDR configures to become a unsigned 64bit value the
>> arm process record code fails resulting in various testsuite failures.
>>
>> gdb:
>>
>> 2014-01-03  Omair Javaid  <omair.javaid@linaro.org>
>>
>> 	* arm-tdep.c (struct arm_mem_r) <addr>: Change type to unit32_t.
> 
> uint32_t.
> 
> Other than that looks fine.
> 
> Thanks,
> 

Made the required change:

gdb:

2014-01-03  Omair Javaid  <omair.javaid@linaro.org>

	* arm-tdep.c (struct arm_mem_r) <addr>: Change type to uint32_t.

---
 gdb/arm-tdep.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 7c78a61..223a7db 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -10618,7 +10618,7 @@ vfp - VFP co-processor."),
 struct arm_mem_r
 {
   uint32_t len;    /* Record length.  */
-  CORE_ADDR addr;  /* Memory address.  */
+  uint32_t addr;   /* Memory address.  */
 };
 
 /* ARM instruction record contains opcode of current insn
-- 
1.7.9.5


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]