This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/5] Fix for D demangling in GDB
- From: Tom Tromey <tromey at redhat dot com>
- To: Iain Buclaw <ibuclaw at gdcproject dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Jan 2014 14:43:19 -0700
- Subject: Re: [PATCH 5/5] Fix for D demangling in GDB
- Authentication-results: sourceware.org; auth=none
- References: <CABOHX+fr7hyD0WM-=1G4zcoJH61uPiE9ezYSYmKuUoqvZnLmvA at mail dot gmail dot com> <87zjn47ref dot fsf at fleche dot redhat dot com> <CABOHX+dXQQjpE2-S3wM5Qcrq=i29HewDzRptXcrn0=T+EVjOrg at mail dot gmail dot com> <CABOHX+dKwZghfF=2KRD8Znj3B5s=knOAdX9VZKBH+8CVBAT1NA at mail dot gmail dot com>
>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
Iain> Couldn't find an easy way to move, then fix. So I did fix, then move.
Thank you.
Iain> +/* Demangle the calling convention from MANGLE and append it to TEMPBUF.
Iain> + Return the remaining string on success or NULL on failure. */
Iain> +static const char *
Iain> +parse_call_convention (struct obstack *tempbuf, const char *mangle)
Blank line between comment and start of function; here and elsewhere.
Iain> +}
Iain> +
Iain> static int
Iain> -extract_type_info (const char *mangled_str, struct obstack *tempbuf)
Iain> +call_convention_p (const char *mangle)
Iain> {
Needs an intro comment.
Iain> + if (mangle && call_convention_p (mangle))
We're trying to use the explicit checking form these days, so
"if (mangle != NULL && ..."
I didn't check the rest of the patch for this nit -- could you take a
look?
Other than the nits and the remaining test suite thing, this looks good.
Thanks again for splitting the patch.
Tom