This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v4 04/13] vla: enable sizeof operator for indirection
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Tom Tromey' <tromey at redhat dot com>
- Cc: "palves at redhat dot com" <palves at redhat dot com>, "xdje42 at gmail dot com" <xdje42 at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Boell, Keven" <keven dot boell at intel dot com>
- Date: Thu, 16 Jan 2014 17:01:13 +0000
- Subject: RE: [PATCH v4 04/13] vla: enable sizeof operator for indirection
- Authentication-results: sourceware.org; auth=none
- References: <1387282678-3847-1-git-send-email-sanimir dot agovic at intel dot com> <1387282678-3847-5-git-send-email-sanimir dot agovic at intel dot com> <8761ploryf dot fsf at fleche dot redhat dot com>
Thanks for you review.
> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Wednesday, January 15, 2014 10:28 PM
> To: Agovic, Sanimir
> Cc: palves@redhat.com; xdje42@gmail.com; gdb-patches@sourceware.org; Boell, Keven
> Subject: Re: [PATCH v4 04/13] vla: enable sizeof operator for indirection
>
> >>>>> "Sanimir" == Sanimir Agovic <sanimir.agovic@intel.com> writes:
>
> Sanimir> 2013-10-18 Sanimir Agovic <sanimir.agovic@intel.com>
> Sanimir> Keven Boell <keven.boell@intel.com>
> Sanimir> * eval.c (evaluate_subexp_for_sizeof): Create a indirect value and
> Sanimir> retrieve the dynamic type size.
>
> I neglected to mention it in the previous patch, but when changing one
> case in a function like this, that consists of little but a big switch,
> it's normal to mention the case, like:
>
> * eval.c (evaluate_subexp_for_sizeof) <UNOP_IND>: ...
>
Will add the mentioned switch case, did not know. Thanks again.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052