This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 16 Jan 2014 19:11:27 +0000
- Subject: Re: [PATCH] Add comments to gdbarch_address_class_name_to_type_flags
- Authentication-results: sourceware.org; auth=none
- References: <52D8293B dot 6060701 at ericsson dot com>
On 01/16/2014 06:47 PM, Simon Marchi wrote:
> +/* Return the appropriate type_flags for the supplied address class.
> + This function should return 1 if the address class was recognized and
> + type_flags was set, zero otherwise.
Say true/false instead of 1/zero.
> + No assumption should be made about the initial value of *type_flags_ptr,
> + which means that if it returns 1, the function should write it, even if
> + no flags are set. */
This makes me a little confused. This is a mapping/conversion function:
class name -> type flags
I'd expect the function to recognize the name, and return a valid flag
(thus return true), or not recognize the name, and return false.
What would "even if no flags are set" mean? What's the use case for that?
Recognizing a class name, but having that map to no flags? As in,
ignoring the class name? Is that useful?
--
Pedro Alves