This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 05/11] Rename varobj_pretty_printed_p to varobj_is_dynamic_p


On 11/23/2013 06:09 PM, Yao Qi wrote:
We think varobj with --available-children-only behaves like a dynamic
varobj, so dyanmic varobj is not pretty-printer specific.  We rename
varobj_pretty_printed_p to varobj_is_dynamic_p, so that we can handle
available-children-only checking in varobj_is_dynamic_p in the next
patch.

One little nit, otherwise, this looks good to me.

Keith


gdb:

2013-11-24  Yao Qi  <yao@codesourcery.com>

	* varobj.c (varobj_pretty_printed_p): Rename to ...
	(varobj_is_dynamic_p): ... this.  New function.
	* varobj.h (varobj_pretty_printed_p): Remove declaration.
	(varobj_is_dynamic_p): Declare.
	* mi/mi-cmd-var.c (print_varobj): Caller update.

"Caller updated" or "Update caller"

	(mi_print_value_p, varobj_update_one): Likewise.
---
  gdb/mi/mi-cmd-var.c |    6 +++---
  gdb/varobj.c        |    4 +++-
  gdb/varobj.h        |    2 +-
  3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/gdb/mi/mi-cmd-var.c b/gdb/mi/mi-cmd-var.c
index 84cdc15..2201630 100644
--- a/gdb/mi/mi-cmd-var.c
+++ b/gdb/mi/mi-cmd-var.c
@@ -88,7 +88,7 @@ print_varobj (struct varobj *var, enum print_values print_values,
        xfree (display_hint);
      }

-  if (varobj_pretty_printed_p (var))
+  if (varobj_is_dynamic_p (var))
      ui_out_field_int (uiout, "dynamic", 1);
  }

@@ -352,7 +352,7 @@ mi_print_value_p (struct varobj *var, enum print_values print_values)
    if (print_values == PRINT_ALL_VALUES)
      return 1;

-  if (varobj_pretty_printed_p (var))
+  if (varobj_is_dynamic_p (var))
      return 1;

    type = varobj_get_gdb_type (var);
@@ -777,7 +777,7 @@ varobj_update_one (struct varobj *var, enum print_values print_values,
  	  xfree (display_hint);
  	}

-      if (varobj_pretty_printed_p (r->varobj))
+      if (varobj_is_dynamic_p (r->varobj))
  	ui_out_field_int (uiout, "dynamic", 1);

        varobj_get_child_range (r->varobj, &from, &to);
diff --git a/gdb/varobj.c b/gdb/varobj.c
index e362229..948f80c 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -1066,8 +1066,10 @@ varobj_get_attributes (struct varobj *var)
    return attributes;
  }

+/* Return true if VAR is a dynamic varobj.  */
+
  int
-varobj_pretty_printed_p (struct varobj *var)
+varobj_is_dynamic_p (struct varobj *var)
  {
    return var->dynamic->pretty_printer != NULL;
  }
diff --git a/gdb/varobj.h b/gdb/varobj.h
index 0f68311..60ace6f 100644
--- a/gdb/varobj.h
+++ b/gdb/varobj.h
@@ -306,7 +306,7 @@ extern void varobj_enable_pretty_printing (void);

  extern int varobj_has_more (struct varobj *var, int to);

-extern int varobj_pretty_printed_p (struct varobj *var);
+extern int varobj_is_dynamic_p (struct varobj *var);

  extern  struct cleanup *varobj_ensure_python_env (struct varobj *var);




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]