This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 22 Jan 2014 08:57:13 +0400
- Subject: Re: [PATCH 2/2] Add ARI (ok) marker for __func__ reference in common-utils.h
- Authentication-results: sourceware.org; auth=none
- References: <20140118015244 dot GA22787 at sourceware dot org> <1390300575-6998-1-git-send-email-brobecker at adacore dot com> <1390300575-6998-2-git-send-email-brobecker at adacore dot com> <CADPb22RhU_a8tRxjo2B-=UfbVEABghuFKC5G09RxBM4sCYXSGQ at mail dot gmail dot com>
> > gdb/ChangeLog:
> >
> > * common/common-utils.h: Add "ARI:" comment besides __func__
> > reference.
> >
> > OK to commit?
>
> Fine by me.
Thanks!
> English nit: "... comment beside __func__ reference".
>
> I wonder though how ARI handled gdb_assert.h (where FUNCTION_NAME
> originates from).
It probably did not - it just became visible again because of
the move (as I understand it, we diff the report with the report
from the previous day, and if we find any additions, we send
them via email, and "diff" is not sophisticated enough to detect
moves).
--
Joel