This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 22 Jan 2014 08:59:56 +0400
- Subject: Re: [PATCH 1/2] Expand documentation of common-utils.h::FUNCTION_NAME
- Authentication-results: sourceware.org; auth=none
- References: <20140118015244 dot GA22787 at sourceware dot org> <1390300575-6998-1-git-send-email-brobecker at adacore dot com> <CADPb22Se+Wm_QvD4bk6Qby3zzOjqx6ROkr4aaKqinx_H5qdgtQ at mail dot gmail dot com>
> > gdb/ChangeLog:
> >
> > * common/common-utils.h (FUNCTION_NAME): Expand the macro's
> > documentation a bit.
> >
> > I would commit on its own, but since I am going to put the next in
> > for the same macro up for review, it's just as easy to make that one
> > wait as well, in case there are comments.
>
> Yeah, I stumbled a bit on this myself.
> It's not clear to me whether not defining it or defining it as NULL
> (and update all current users to deal with that) is better but I went
> with keeping things as they are.
I almost had the same thoughts. I agree that it's just best to let
things as they are until we have evidence that changing them would
be beneficial. The difference is that I was thinking of defining
FUNCTION_NAME to something like "<unknown function>" rather than NULL.
Without more evidence, not clear which would be best...
--
Joel