This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
xtensa-config.c: missing defs.h include.
- From: Pedro Alves <palves at redhat dot com>
- To: Baruch Siach <baruch at tkos dot co dot il>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 22 Jan 2014 12:16:18 +0000
- Subject: xtensa-config.c: missing defs.h include.
- Authentication-results: sourceware.org; auth=none
- References: <db6eeeae015d93276f85b4323903afb804cb255d dot 1389877349 dot git dot baruch at tkos dot co dot il> <52D80DC6 dot 5030703 at redhat dot com> <20140122044836 dot GL12751 at tarshish>
On 01/22/2014 04:48 AM, Baruch Siach wrote:
> Hi Pedro,
>
> On Thu, Jan 16, 2014 at 04:50:14PM +0000, Pedro Alves wrote:
>> On 01/16/2014 01:02 PM, Baruch Siach wrote:
>>> On 64 bit hosts unsigned long is 64 bit. Use uint32_t instead.
>>>
>>> * xtensa-tdep.h (xtensa_elf_greg_t): Change type to uint32_t
>>
>> Missing period.
>>
>> OK (and obvious).
>
> Should I resend?
No need. I'll push tweak and push it, but ...
>
> baruch
>
>>> ---
>>> gdb/xtensa-tdep.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/gdb/xtensa-tdep.h b/gdb/xtensa-tdep.h
>>> index 968b9d2916b7..d7ba5628e42a 100644
>>> --- a/gdb/xtensa-tdep.h
>>> +++ b/gdb/xtensa-tdep.h
>>> @@ -84,7 +84,7 @@ typedef enum
>>> /* Xtensa ELF core file register set representation ('.reg' section).
>>> Copied from target-side ELF header <xtensa/elf.h>. */
>>>
>>> -typedef unsigned long xtensa_elf_greg_t;
>>> +typedef uint32_t xtensa_elf_greg_t;
>>>
>>> typedef struct
>>> {
>>>
>
... this actually doesn't build.
gcc -g3 -O0 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o xtensa-tdep.o -MT xtensa-tdep.o -MMD -MP -MF .deps/xtensa-tdep.Tpo ../../src/gdb/xtensa-tdep.c
In file included from ../../src/gdb/xtensa-config.c:23:0:
../../src/gdb/xtensa-tdep.h:87:1: error: unknown type name ‘uint32_t’
I'm applying this fix first:
---------
xtensa-config.c: missing defs.h include.
All .c files must start by including defs.h.
2014-01-22 Pedro Alves <palves@redhat.com>
* xtensa-config.c: Include defs.h.
---
gdb/ChangeLog | 4 ++++
gdb/xtensa-config.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index caed724..107ed98 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2014-01-22 Pedro Alves <palves@redhat.com>
+
+ * xtensa-config.c: Include defs.h.
+
2014-01-22 Joel Brobecker <brobecker@adacore.com>
* common/common-utils.h: Add "ARI:" comment beside __func__
diff --git a/gdb/xtensa-config.c b/gdb/xtensa-config.c
index 19a33bb..345b334 100644
--- a/gdb/xtensa-config.c
+++ b/gdb/xtensa-config.c
@@ -17,6 +17,8 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+#include "defs.h"
+
#define XTENSA_CONFIG_VERSION 0x60
#include "xtensa-config.h"
--
1.7.11.7