This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] testsuite: Fix gdb.dwarf2/dw2-case-insensitive.exp testcase for ppc64
- From: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 28 Jan 2014 16:19:59 -0200
- Subject: Re: [PATCH] testsuite: Fix gdb.dwarf2/dw2-case-insensitive.exp testcase for ppc64
- Authentication-results: sourceware.org; auth=none
- References: <201401281601 dot s0SG1lJW004119 at d06av02 dot portsmouth dot uk dot ibm dot com>
On 01/28/2014 02:01 PM, Ulrich Weigand wrote:
> If the problem is indeed that FUNC_lang_end is at the same location as
> FUNC_symtab, maybe a better fix would be to add some padding in between
> (e.g. a ".byte 0" after the FUNC_lang_end label)?
Thanks Uli for the review. I've tested your suggestion and it fixed the problem
on ppc64. It was also successfully tested on x86.
If someone could take a look and check if this change doesn't affect the results
on arm, that would be great.
Thanks,
--
Edjunior
gdb/testsuite/
2014-01-28 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
* gdb.dwarf2/dw2-case-insensitive.c: Add padding after FUNC_lang_end
label.
---
gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c b/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
index 9ec7b25..48a0694 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
+++ b/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
@@ -30,6 +30,7 @@ FUNC_lang (void)
asm (".globl FUNC_lang_end");
asm ("FUNC_lang_end:");
+asm (".byte 0");
/* Symbol is present only in ELF .symtab. */
--
1.7.9.5