This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 07/11] ELFv2 ABI: base support
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 29 Jan 2014 08:42:12 +0400
- Subject: Re: [PATCH 07/11] ELFv2 ABI: base support
- Authentication-results: sourceware.org; auth=none
- References: <201401281729 dot s0SHTIEk021004 at d06av02 dot portsmouth dot uk dot ibm dot com>
> ChangeLog:
>
> * ppc-tdep.h (enum powerpc_elf_abi): New data type.
> (struct gdbarch_tdep): New member elf_abi.
>
> * rs6000-tdep.c: Include "elf/ppc64.h".
> (rs6000_gdbarch_init): Detect ELF ABI version.
Maybe one suggestion....
> + /* Default to ELFv2 ABI on 64-bit little-endian, and ELFv1 otherwise. */
> + if (elf_abi == POWERPC_ELF_AUTO)
I thik it would be useful to explain why. IIUC, that's because we want
to preserve the legacy behavior where we have been using ELF_V1, while
we know that ppc64le has been V2 from the start.
--
Joel