This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] Remove argument optional_p from get_tracepoint_by_number
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 5 Mar 2014 06:44:46 -0800
- Subject: Re: [PATCH 4/4] Remove argument optional_p from get_tracepoint_by_number
- Authentication-results: sourceware.org; auth=none
- References: <1394023608-10761-1-git-send-email-yao at codesourcery dot com> <1394023608-10761-5-git-send-email-yao at codesourcery dot com>
> This patch is to remove parameter optional_p as it is always true,
> in order to simplify get_tracepoint_by_number.
>
> 'optional_p' was added by this change,
>
> 1999-11-18 Tom Tromey <tromey@cygnus.com>
>
> * tracepoint.h (get_tracepoint_by_number): Updated
> declaration.
> * tracepoint.c (trace_pass_command): Better error message.
> Fixed logic when `all' not specified.
> (get_tracepoint_by_number): Added `optional_p' argument. Fixed
> all callers.
>
> but after this patch,
>
> FYI: remove `static's from cli-utils.c
> https://sourceware.org/ml/gdb-patches/2011-03/msg00636.html
>
> 'optional_p' passed to get_tracepoint_by_number become always true.
FWIW - don't know much about this code, but this patch looks fine to me.
--
Joel