This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] gdb/python: raise TypeError instead of abort() on calling .value() method for label symbol object
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Maxim Bublis <satori at yandex-team dot ru>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 06 Mar 2014 08:37:50 +0000
- Subject: Re: [PATCH 2/3] gdb/python: raise TypeError instead of abort() on calling .value() method for label symbol object
- Authentication-results: sourceware.org; auth=none
- References: <1393929360-31299-1-git-send-email-satori at yandex-team dot ru> <1393929360-31299-3-git-send-email-satori at yandex-team dot ru> <53161401 dot 5080408 at redhat dot com> <07E7B14B-748D-4CF7-A8AD-623AF5D6E701 at yandex-team dot ru>
On 05/03/14 13:39, Maxim Bublis wrote:
>
>> This patch looks fine to me apart from one further small aside (please
>> wait for a maintainer to approve your patch, regardless). In the
>> documentation you note there are other types of symbol that can
>> produce this error: e.g., SYMBOL_LOC_TYPEDEF. Can you please audit and
>> include checks for all, while you are there? I noticed only the
>> explicit LOC_LABEL check in the patch above.
>
> There is already implemented similar behavior for LOC_TYPEDEF, so no additional work here should be done.
> On the other hand there is no testcase for typedef symbol object .value() method call.
> Maybe you could provide me a help with writing such testcase as I do not quietly understand how typedef symbol object could be retrieved.
That's fine, if it is already implemented. I think the above should
be tested, but it represents a segue to your patch functionality, so
should not block it. I am fine with the patch in the second
revision. Please wait for a maintainer to give the go ahead.
Cheers,
Phil