This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR16508


> if [prepare_for_testing "failed to prepare for trace tests" \
> 	$executable $srcfile [list debug]] {
> 
> Although we do that all over the place, passing $expfile
> to untested is useless, as that information will be
> in the gdb.sum before UNTESTED anyway.
> 
> I'd support us starting to use this pattern more.

I think that's a good idea. I've updated the Wiki's "testcase cookbook"
accordingly. My only concern with the current verbiage is copy/pasting
of existing examples will always require some additional edits to
adjust the message for the testcase. In the wiki example, I used
"[***FILL ME IN***]" which (I think) will cause a TCL error, but
the favorite programming method being copy-and-modify, I think we are
going to miss some. So perhaps something a little more generic?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]