This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR16508
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Thu, 6 Mar 2014 05:35:44 -0800
- Subject: Re: [PATCH] Fix PR16508
- Authentication-results: sourceware.org; auth=none
- References: <1392447370-22318-1-git-send-email-yao at codesourcery dot com> <87lhwo76qv dot fsf at fleche dot redhat dot com> <53178A28 dot 8060206 at redhat dot com>
> if [prepare_for_testing "failed to prepare for trace tests" \
> $executable $srcfile [list debug]] {
>
> Although we do that all over the place, passing $expfile
> to untested is useless, as that information will be
> in the gdb.sum before UNTESTED anyway.
>
> I'd support us starting to use this pattern more.
I think that's a good idea. I've updated the Wiki's "testcase cookbook"
accordingly. My only concern with the current verbiage is copy/pasting
of existing examples will always require some additional edits to
adjust the message for the testcase. In the wiki example, I used
"[***FILL ME IN***]" which (I think) will cause a TCL error, but
the favorite programming method being copy-and-modify, I think we are
going to miss some. So perhaps something a little more generic?
--
Joel