This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v5 08/15] vla: support for DW_AT_count
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Joel Brobecker' <brobecker at adacore dot com>
- Cc: "tromey at redhat dot com" <tromey at redhat dot com>, "Boell, Keven" <keven dot boell at intel dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 12 Mar 2014 13:51:01 +0000
- Subject: RE: [PATCH v5 08/15] vla: support for DW_AT_count
- Authentication-results: sourceware.org; auth=none
- References: <1391704056-25246-1-git-send-email-sanimir dot agovic at intel dot com> <1391704056-25246-9-git-send-email-sanimir dot agovic at intel dot com> <20140228165300 dot GA16479 at adacore dot com>
Thanks for your review.
> Overall, the patch looks OK to me, but I'd rather we be consistent
> with what we've been doing with other type flags, and use a bitfield
> instead. I think that'll simplify your patch a bit.
>
I`m using bitfields now but they are still part of the struct range_bounds
and not struct main_type as they are specific to arrays and not types in
general.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052