This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC PATCH] Allow disabling the default run target.


> Date: Fri, 14 Mar 2014 11:06:32 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> On 03/13/2014 08:16 PM, Eli Zaretskii wrote:
> >> From: Pedro Alves <palves@redhat.com>
> >> Date: Thu, 13 Mar 2014 19:02:48 +0000
> >>
> >> Wonder what people think of this.
> > 
> > FWIW, the names of commands and options confused me a lot.
> 
> Thanks Eli.  I battled with several different namings, and
> all the others seemed worse.  :-)  But I do think we should
> try to come up with something better -- always a bad sign
> to me when a GDB maintainer is confused.  Probably users
> will be even more.
> 
> Can you point out specifically what confused you?

"target child" itself, and then the apparent disconnect between that
and the option name, although NEWS says that "'target child' [...]
connects to the default run target".  Also, the fact that setting
default-run-target to OFF actually _enables_ something (AFAIU).

> I've been pondering renaming "target child" to something else.
> "child" is a little lie in case of "attach".
> By best suggestion so far is "target native".

"target native" is a much better name, IMO.

> Not sure whether djgpp even supports remote debugging

AFAIK, it does, see ser-go32.c.  But if you meant remote debugging of
DJGPP programs, then no, this isn't supported, since gdbserver
doesn't, and there's no other stub that could do that instead.

> I'd suggest just removing go32_open, and letting inf-child.c's
> to_open handle pushing the target.

Fine with me.  I don't think "target djgpp" was ever important anyway,
I think it's there mostly for completeness.

> For the toggle option itself, I considered putting "enable" in the name:
> 
>  set enable-default-run-target
> 
> But disabling this isn't really disabling the target, only
> the falling back is disabled.  Adding "fallback" and/to "to"
> seems to help.  Like:
> 
>  set enable-fallback-to-default-run-target
>  set enable-fallback-default-run-target
>  set fallback-to-default-run-target
>  set fallback-default-run-target
> 
> Seemed a little too long, so I ended up dropping the "fallback".
> Dunno, maybe tab completion makes that a non-issue.
> 
> Assuming using "native" instead would be OK, I think we could
> dispense with "default", like:
> 
>  set enable-fallback-to-native-target
>  set enable-fallback-native-target
>  set fallback-to-native-target
>  set fallback-native-target
>  set native-target-fallback
> 
> (and then "target child" renamed to "target native").

Maybe we should take a step back and discuss why this fallback is
useful.  Is it only so native debugging works by default without a
need to say "target native"?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]