This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC 00/12 V2] Visit varobj available children only in MI


On 02/14/2014 04:44 PM, Yao Qi wrote:
> This is the V2 of this patch series, addressing Keith's review comments
> to V1 (reviewed in Jan 2014).  The general description of this series
> can be found https://sourceware.org/ml/gdb-patches/2013-11/msg00739.html
> 
> Changes in V2 are:
> 
>  - Include NEWS and doc.
>  - Fix typos, grammatical mistakes, and changelog entries.
>  - Update copyright year from "2013" to "2013-2014" for new files.
>  - Use -list-features to return "available-children-only" (#7).
>  - Update config/djgpp/fnchange.lst for new tests.
>  - Fix a missing cleanup (#2).
>  - Call varobj_delete_iter in free_variable (#3).
> 
> Regression tested on x86_64-linux.
> 

Ping.  https://sourceware.org/ml/gdb-patches/2014-02/msg00489.html

Can anyone have a look at this patch?  Patch 11/12 still depends on
"[PATCH] Accept convenience variable in commands -break-passcount and
-break-commands", but it doesn't matter much for reviewing this patch
series.

IMO, patches #1 - #6 are refactor to existing code on dynamic varobj,
and can go in regardless of the decision of the rest (MI option
--available-children-only stuff).  WDYT?

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]