This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Commit: ARM SIM: Add tracing support.


Hi Doug,

So I guess I have more questions.
What happens if you remove all -t option parsing from your patch, and
just let the existing code handle it?

It still works. :-{

And  what happens if you remove -d and -z parsing from sim_open in
your patch, and leave it to just sim_target_parse_command_line?

Also works. :-{

Why parse them in two places?

Paranoia - I am unfamiliar with the simulator command line handling framework and there was already code in both places to handle other options, so I assumed that it was necessary.


I will check in a new patch to delete the redundant code - plus do a little bit of formatting tidying to wrapper.c.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]