This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] constify value_aggregate_elt
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 31 Mar 2014 11:26:22 -0600
- Subject: Re: [PATCH] constify value_aggregate_elt
- Authentication-results: sourceware.org; auth=none
- References: <1395951100-8142-1-git-send-email-tromey at redhat dot com> <20140328131959 dot GH4030 at adacore dot com>
>> * valops.c (value_aggregate_elt, value_struct_elt_for_reference)
>> (value_namespace_elt, value_maybe_namespace_elt): Make "name"
>> const.
>> * value.h (value_aggregate_elt): Update.
Joel> Any reason for delaying the push on these types of patches?
A while ago I was asked not to commit things without a waiting period.
So I wait at least a week unless I think it is truly obvious and
controversy-free; or if someone asks for the patch earlier.
My belief is that constification has not been without its battles, hence
the wait.
Tom