This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/8] Remove Guile GDB object property mechanism
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Andy Wingo <wingo at igalia dot com>
- Cc: gdb-patches at sourceware dot org, wingo at igalia dot com
- Date: Wed, 09 Apr 2014 19:36:56 +0300
- Subject: Re: [PATCH 5/8] Remove Guile GDB object property mechanism
- Authentication-results: sourceware.org; auth=none
- References: <1397059725-18066-1-git-send-email-wingo at igalia dot com> <1397059725-18066-9-git-send-email-wingo at igalia dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Andy Wingo <wingo@igalia.com>
> Cc: Andy Wingo <wingo@igalia.com>
> Date: Wed, 9 Apr 2014 18:08:37 +0200
>
> * gdb/guile/guile-internal.h: Remove scm_gsmob / GDB_SMOB_HEAD base
> type; it only served as something to which object properties could be
> attached: a use case already served by Guile's own object properties.
> (gdbscm_init_gsmob, gdbscm_mark_gsmob, gdbscm_mark_chained_gsmob)
> (gdbscm_mark_eqable_gsmob): Remove these now-unneeded functions.
>
> * gdb/guile/scm-gsmob.c (gdbscm_init_gsmob, gdbscm_mark_gsmob)
> (gdbscm_mark_chained_gsmob, gdbscm_mark_eqable_gsmob): Remove.
> (gdbscm_gsmob_property, gdbscm_set_gsmob_property_x)
> (gdbscm_gsmob_has_property_p, add_property_name)
> (gdbscm_gsmob_properties): Remove these public interfaces, and remove
> them from gsmob_functions.
>
> * gdb/guile/scm-arch.c:
> * gdb/guile/scm-block.c:
> * gdb/guile/scm-breakpoint.c:
> * gdb/guile/scm-exception.c:
> * gdb/guile/scm-frame.c:
> * gdb/guile/scm-iterator.c:
> * gdb/guile/scm-lazy-string.c:
> * gdb/guile/scm-objfile.c:
> * gdb/guile/scm-pretty-print.c:
> * gdb/guile/scm-symbol.c:
> * gdb/guile/scm-symtab.c:
> * gdb/guile/scm-type.c:
> * gdb/guile/scm-value.c: Adapt to not include a gdb_gsmob base member,
> for basic gsmobs, and to not call init/mark functions.
>
> * gdb/doc/guile.texi (GDB Scheme Data Types): Update.
OK for the documentation part.