This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2
- From: Doug Evans <xdje42 at gmail dot com>
- To: Andy Wingo <wingo at igalia dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 12 Apr 2014 09:47:46 -0700
- Subject: Re: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2
- Authentication-results: sourceware.org; auth=none
- References: <1397060028-18158-1-git-send-email-wingo at igalia dot com> <1397060028-18158-2-git-send-email-wingo at igalia dot com> <m3eh12tsag dot fsf at sspiff dot org>
On Sat, Apr 12, 2014 at 9:40 AM, Doug Evans <xdje42@gmail.com> wrote:
> This is ok with two nits:
>
> 1) ChangeLog entries are included in the email as they appear in the file
> itself (but not as a patch). E.g., for future reference, replace
>
> * gdb/configure:
> * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2.
>
> with
>
> 2014-04-09 Andy Wingo <wingo@igalia.com>
>
> * gdb/configure:
> * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2.
Oops. Make that
2014-04-09 Andy Wingo <wingo@igalia.com>
* configure: Regenerate.
* configure.ac (try_guile_versions): Allow building with guile 2.2.
Paths in ChangeLog files are relative to the location of the ChangeLog file.
And convention is to write "Regenerate" for machine generated files.
Plus, instead of "replace" I should have probably said "in addition to".
Feel free to include whatever git spits out of course, but current
community rules require the ChangeLog entry included in the emailed
patch as shown above.
[There is debate on how to improve this, but I don't think the
community has agreed to anything yet.]