This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: fix PR backtrace/15558


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> See patch below.  I've simplified your test a bit, and added a test
Pedro> that doesn't depend on Python, to the existing gdb.opt/inline-bt.exp.

Thanks.

Pedro> Not sure.  I guess Python code might want to be implementing some
Pedro> new frame-related CLI command, where the limits make sense.  Maybe
Pedro> Python should really have access to both variants, somehow?

I was thinking perhaps new methods on the python frame object.

Pedro> 	PR backtrace/15558
Pedro> 	* gdb.opt/inline-bt.exp: Test backtracing from an inline function
Pedro> 	with a backtrace limit.
Pedro> 	* py-frame-inline.exp: Test running to an inline function with a
Pedro> 	bactrace limit, and printing the newest frame.

Typo in "backtrace" on the last line.

The patch looks good but the ChangeLog has a missing directory name and
doesn't mention :

>  gdb/testsuite/gdb.python/py-frame-inline.c   |  4 +++-

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]