This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA testsuite 3/5] Introduce mi_make_breakpoint
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Thu, 17 Apr 2014 14:40:38 -0600
- Subject: Re: [RFA testsuite 3/5] Introduce mi_make_breakpoint
- Authentication-results: sourceware.org; auth=none
- References: <534ED159 dot 8050304 at redhat dot com>
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> 2014-04-15 Keith Seitz <keiths@redhat.com>
Keith> * lib/mi-support.exp (mi_create_breakpoint): Use mi_make_breakpoint
Keith> and return the result.
Keith> (mi_make_breakpoint): New procedure.
One nit below.
Keith> + parse_args {{number .*} {type .*} {disp .*} {enabled .*} {addr .*} \
Keith> + {func .*} {file .*} {fullname .*} {line .*} \
Keith> + {thread-groups \\\[.*\\\]} {times .*} {ignore 0} \
Keith> + {script ""} {original-location .*}}
I don't think the backslashes are needed at the ends of lines here.
The outer braces ought to be sufficient.
This is ok with this change.
Tom