Re: [patch] [gdb/testsuite] Move start-of-function brace to handle Clang/GCC difference

[Doug Evans <dje at google dot com>]

David Blaikie writes:
 > gdb.cp/cpexprs.exp is verifying behavior that's likely a GCC bug (GCC
 > PR60815 and some in person and IRC conversations with GCC developers).
 > GCC inconsistently places the prologue on either the line with the
 > function name or the line with the function's open brace. Clang
 > consistently uses the function's open brace.
 > 
 > Either these tests can be fixed by moving the line to break on and
 > XFAILing them all under GCC, or just making the test neutral to the
 > bug by moving the brace. I generally think it's best to just make the
 > test bug-neutral.
 > 
 > I've also had to update the .exp file to tolerate differences in the
 > type of vtable pointers (GCC's "const void ** const" versus Clang's
 > "void **") which required some refactoring.
 > commit c532bc93335823e6ddbaa58abe6f5f58a1dda62e
 > Author: David Blaikie <dblaikie@gmail.com>
 > Date:   Sun Apr 13 17:37:56 2014 -0700
 > 
 >     Adjust start-of-function braces to be compatible with Clang
 >     
 >     gdb/testsuite/
 >     	* gdb.cp/cpexprs.cc: Move braces to the same line as the start
 >     	of the function to work across GCC and Clang.
 >     	* gdb.cp/cpexprs.exp: Account for GCC/Clang difference in vtable
 >     	pointer types (const void ** const V void **).

I'm don't have an opinion, so in the interests of moving things along,
and since the patch has been out for awhile,
let's go with this.

When you commit this, *please* add the entirety of the above text to the commit entry.

Thanks!