This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCHv4] aarch64: detect atomic sequences like other ll/sc architectures
- From: Kyle McMartin <kmcmarti at redhat dot com>
- To: Andrew Pinski <pinskia at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Joel Brobecker <brobecker at adacore dot com>
- Date: Thu, 24 Apr 2014 14:51:19 -0400
- Subject: Re: [PATCHv4] aarch64: detect atomic sequences like other ll/sc architectures
- Authentication-results: sourceware.org; auth=none
- References: <20140424183510 dot GI7588 at redacted dot bos dot redhat dot com> <CA+=Sn1mWke-_8O0-rJb5186MLZMOqtq46hBfNueW_v0BS13fzw at mail dot gmail dot com>
On Thu, Apr 24, 2014 at 11:38:57AM -0700, Andrew Pinski wrote:
> > + uint32_t insn = read_memory_unsigned_integer (loc, insn_size, byte_order);
>
>
> I think this is broken for big-endian aarch64. Instructions are
> always in little-endian mode so we really should be reading them
> always as little-endian.
>
You're right, I meant to do gdbarch_byte_order_for_code as is done
elsewhere in tdep for AArch64... will resend.
regards,
--Kyle