This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/2] Demangler crash handler
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: gbenson at redhat dot com, gdb-patches at sourceware dot org
- Date: Sat, 10 May 2014 22:55:03 +0200
- Subject: Re: [PATCH 0/2] Demangler crash handler
- Authentication-results: sourceware.org; auth=none
- References: <20140509100656 dot GA4760 at blade dot nx> <201405091120 dot s49BKO1f010622 at glazunov dot sibelius dot xs4all dot nl>
* Mark Kettenis:
> No. It's this skind of duct-tape that will make sure that bugs in the
> demangler won't get fixed. Apart from removing the incentive to fix
> the bugs, these SIGSEGV signal handlers make actually fixing the bugs
> harder as you won't have core dumps.
I find this approach extremely odd as well.
> Besides, any signal handler that does more than just setting a flag is
> probably broken. Did you verify that you only call async-signal-safe
> functions in the signal handler code path?
At least it doesn't make things much worse because the program is
already in a funny state when the signal is generated.
It would be more reliable to run the demangler in a separate process.
What's so difficult about fixing the demangler?