This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Import the "dirfd" gnulib module
- From: Tom Tromey <tromey at redhat dot com>
- To: Gregory Fong <gregory dot 0xf0 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 16 May 2014 08:43:43 -0600
- Subject: Re: [PATCH] Import the "dirfd" gnulib module
- Authentication-results: sourceware.org; auth=none
- References: <1392676734-737-1-git-send-email-gregory dot 0xf0 at gmail dot com> <87tx8q96cm dot fsf at fleche dot redhat dot com> <CADtm3G5H_3GTz+O6TXm-PWW4PufE4J358JF4-0Xn=JpGgfHiWQ at mail dot gmail dot com>
>>>>> "Gregory" == Gregory Fong <gregory.0xf0@gmail.com> writes:
Gregory> On Thu, May 15, 2014 at 12:42 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "Gregory" == Gregory Fong <gregory.0xf0@gmail.com> writes:
>>
Gregory> This imports the gnulib dirfd module so that LSB 3.0 can be targeted
Gregory> when building gdb with the LSB SDK. It doesn't make any other changes
Gregory> to gdb.
>>
>> I'm sorry nobody reviewed your patch earlier.
>>
>> I think importing the dirfd module is probably fine, but I confess I
>> don't really understand the rationale. I'm going to guess that dirfd
>> isn't in LSB 3.0 but gnulib works around this ... ?
Gregory> Yes, that's correct. I posted a more thorough explanation earlier at
Gregory> https://sourceware.org/ml/gdb/2014-02/msg00034.html
Thanks. I'd completely forgotten about that.
The patch is fine.
I can check it in for you if you need that.
Tom