This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] linux_nat_kill() compat. with linux-2.4.x
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 21 May 2014 13:49:43 +0100
- Subject: Re: [patch] linux_nat_kill() compat. with linux-2.4.x
- Authentication-results: sourceware.org; auth=none
- References: <20140316135916 dot GA31463 at host2 dot jankratochvil dot net>
Hi Jan,
On 03/16/2014 01:59 PM, Jan Kratochvil wrote:
> gdb/
> 2014-03-16 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> PR gdb/15358
> * linux-nat.c (linux_nat_kill): Use kill_callback first.
> Extend the comment for stop_callback.
>
> diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
> index b615423..ec84188 100644
> --- a/gdb/linux-nat.c
> +++ b/gdb/linux-nat.c
> @@ -3777,8 +3777,15 @@ linux_nat_kill (struct target_ops *ops)
> {
> ptid_t ptid = pid_to_ptid (ptid_get_pid (inferior_ptid));
>
> + /* Kill all LWP's before trying to stop them. In rare cases the
> + lwp_info state may not match the inferior and
> + stop_wait_callback could lock up. */
Hmm, I find this comment confusing and not really enlightening.
What sort of rare cases? It that PR15713? Best just fix that.
I've sent a patch:
https://sourceware.org/ml/gdb-patches/2014-05/msg00473.html
--
Pedro Alves