This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 3/4] Deprecate frame_stop_reason_string.
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>, gdb-patches at sourceware dot org
- Date: Thu, 29 May 2014 10:56:35 +0100
- Subject: Re: [PATCH v3 3/4] Deprecate frame_stop_reason_string.
- Authentication-results: sourceware.org; auth=none
- References: <533EC5B7 dot 6080600 at broadcom dot com> <1398855344-25278-1-git-send-email-aburgess at broadcom dot com> <1398855344-25278-4-git-send-email-aburgess at broadcom dot com> <53861C53 dot 5060402 at redhat dot com> <538670AE dot 3050305 at broadcom dot com> <5386F73C dot 8000102 at redhat dot com> <53870363 dot 20502 at broadcom dot com>
On 05/29/2014 10:52 AM, Andrew Burgess wrote:
> On 29/05/2014 10:00 AM, Pedro Alves wrote:
>> This still has "frame" in the name, and misses the "to". Any reason for that?
>
> No, just me being special :)
LOL!
> This function is confusingly named, the "frame_" in the name implies it
> somehow is frame dependent, when in reality the function just converts an
> 'enum unwind_stop_reason' value to a string.
Excellent and concise description/log.
>
> gdb/ChangeLog:
>
> * frame.c (frame_stop_reason_string): Rename to ...
> (unwind_stop_reason_to_string): this.
> * frame.h (frame_stop_reason_string): Rename to ...
> (unwind_stop_reason_to_string): this.
> * stack.c (frame_info): Update call to frame_stop_reason_string.
> (backtrace_command_1): Likewise.
> * guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Likewise.
> * python/py-frame.c (gdbpy_frame_stop_reason_string): Likewise.
OK
Thanks,
Pedro Alves