This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] PR python/16699: GDB Python command completion with overriden complete vs. completer class
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Doug Evans <xdje42 at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 08 Jul 2014 17:30:12 -0300
- Subject: Re: [PATCH] PR python/16699: GDB Python command completion with overriden complete vs. completer class
- Authentication-results: sourceware.org; auth=none
- References: <m3iorj3ud8 dot fsf at redhat dot com> <87a9btqhe3 dot fsf at fleche dot redhat dot com> <m361ln20e8 dot fsf at redhat dot com> <87y4xwqn71 dot fsf at fleche dot redhat dot com> <m3ha4jevbq dot fsf at redhat dot com> <m3mweb6096 dot fsf at sspiff dot org> <m3fviluc6a dot fsf at redhat dot com> <20140708153221 dot GA15767 at host2 dot jankratochvil dot net>
On Tuesday, July 08 2014, Jan Kratochvil wrote:
> Hi Sergio,
>
> the testcase FAILs with "read1" from:
> reproducer for races of expect incomplete reads
> http://sourceware.org/bugzilla/show_bug.cgi?id=12649
>
> Additionally the testcase uses $objdir instead of [standard_output_file],
> filed for it now tracking PR:
> $objdir and $subdir should be tainted
> https://sourceware.org/bugzilla/show_bug.cgi?id=17129
On Tuesday, July 08 2014, Jan Kratochvil wrote:
> On Tue, 08 Jul 2014 17:32:21 +0200, Jan Kratochvil wrote:
>> - -re "^completefilecommandcond ${objdir}/${subdir}/py-completion-t$" {
>> + -re "^completefilecommandcond ${completion_regex}$" {
>
> There was a racy bug here - and even in the former test - here should be:
> + -re "^completefilecommandcond ${completion_regex}\007$" {
>
> Updated fix attached.
Hello Jan,
Thank you for the catches. I will update my local version.
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/