This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/7 v2] Merge {i386,amd64}_linux_read_description
- From: Pedro Alves <alves dot ped at gmail dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, Pedro Alves <palves at redhat dot com>
- Date: Wed, 09 Jul 2014 14:07:34 +0100
- Subject: Re: [PATCH 2/7 v2] Merge {i386,amd64}_linux_read_description
- Authentication-results: sourceware.org; auth=none
- References: <1403878351-22974-1-git-send-email-gbenson at redhat dot com> <1403878351-22974-3-git-send-email-gbenson at redhat dot com>
On 06/27/2014 03:12 PM, Gary Benson wrote:
> This commit merges i386_ and amd64_linux_read_description, renaming
> both to x86_linux_read_description.
>
> This patch differs from the original version in this series
> in that x86_linux_read_description is much cleaner, having
> been rewritten to avoid "#ifdef spaghetti".
>
> gdb/
> 2014-06-27 Gary Benson <gbenson@redhat.com>
>
> * amd64-linux-nat.c (amd64_linux_read_description): Renamed to
> x86_linux_read_description. All uses updated. amd64-specific
> code conditionalized. Conditionalized i386-specific code added.
> Redundant cast removed.
> * i386-linux-nat.c (i386_linux_read_description): Renamed to
> x86_linux_read_description. All uses updated. i386-specific
> code conditionalized. Conditionalized amd64-specific code added.
> One sizeof replaced with the actual type it is describing.
I compared the old vs new files side by side to try to check that
the merged code behaved the same the as before. This version does
look much cleaner.
Looks good to me, thanks.
--
Pedro Alves