This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 6/7 v2] Move duplicated code into new files
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Date: Wed, 09 Jul 2014 14:12:27 +0100
- Subject: Re: [PATCH 6/7 v2] Move duplicated code into new files
- Authentication-results: sourceware.org; auth=none
- References: <1403878351-22974-1-git-send-email-gbenson at redhat dot com> <1403878351-22974-7-git-send-email-gbenson at redhat dot com>
On 06/27/2014 03:12 PM, Gary Benson wrote:
> This commit moves the shared code in {i386,amd64}-linux-nat.c
Nit: s/shared/identical/. It's only shared afterwards.
> into the new files x86-linux-nat.[ch]. Additionally, a new
> file i386-linux-nat.h was required to expose a value required
> by the 32-bit code in x86-linux-nat.c.
>
> This patch differs from the original version in this series
> in that x86_linux_read_description has been rewritten in an
> earlier patch.
> (x86_linux_dr_get_addr): Likewise.
> (x86_linux_dr_get_control) Likewise.:
Typo, ':' position.
> (x86_linux_dr_get_status): Likewise.
Otherwise looks good to me.
Thanks,
--
Pedro Alves