This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Handle OP_STRING in dump_subexp_body_standard
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 15 Jul 2014 08:00:59 -0700
- Subject: Re: [PATCH] Handle OP_STRING in dump_subexp_body_standard
- Authentication-results: sourceware.org; auth=none
- References: <1403189133-7667-1-git-send-email-simon dot marchi at ericsson dot com> <53BC0E20 dot 7000402 at ericsson dot com> <20140715132008 dot GD4888 at adacore dot com> <53C53EA4 dot 1090102 at ericsson dot com>
> >>> gdb/ChangeLog:
> >>>
> >>> 2014-06-19 Simon Marchi <simon.marchi@ericsson.com>
> >>>
> >>> * expprint.c (dump_subexp_body_standard): Handle OP_STRING.
[...]
> > So, I would say that it should be "elt + 1" for variable "type".
>
> You are totally right.
>
> >>> + /* Skip string content. */
> >>> + elt += BYTES_TO_EXP_ELEM(len);
> >
> > Missing space before '('.
>
> Ack.
>
> Thanks for the review. Do these small fixes warrant a v2?
OK, pre-approved with the changes above, but our procedures do require
you to re-post a patch whenever what's committed is different from
what was originally posted. I'd say, make the modifications, test them,
commit & push, and then reply to this thread with the updated patch.
Thank you,
--
Joel