This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/arm-linux-tdep.c: Handle Thumb signal trampolines
- From: Pedro Alves <palves at redhat dot com>
- To: Will Newton <will dot newton at linaro dot org>, gdb-patches at sourceware dot org
- Date: Thu, 24 Jul 2014 02:17:20 +0100
- Subject: Re: [PATCH] gdb/arm-linux-tdep.c: Handle Thumb signal trampolines
- Authentication-results: sourceware.org; auth=none
- References: <1406046118-3127-1-git-send-email-will dot newton at linaro dot org>
On 07/22/2014 05:21 PM, Will Newton wrote:
> Recent versions of glibc have assembled the signal trampoline code
> as Thumb, which causes gdb to misinterpret them and a number of
> testsuite tests to fail. Educate gdb about these trampolines and
> get the tests running again.
For a moment you had me! The subject/intro made me believe
you were talking about Thumb 1. Could you update them to
mention "Thumb 2" explicitly, when you push this in?
This looks good to me.
Tiny nit below.
> @@ -246,6 +246,12 @@ static const gdb_byte arm_linux_thumb2_le_breakpoint[] = { 0xf0, 0xf7, 0x00, 0xa
> #define ARM_SET_R7_RT_SIGRETURN 0xe3a070ad
> #define ARM_EABI_SYSCALL 0xef000000
>
Could you add a comment here? Like:
/* Likewise for Thumb 2. */
( Feel free to expand if it makes sense. :-) )
> +#define THUMB2_SET_R7_SIGRETURN1 0xf04f
> +#define THUMB2_SET_R7_SIGRETURN2 0x0777
> +#define THUMB2_SET_R7_RT_SIGRETURN1 0xf04f
> +#define THUMB2_SET_R7_RT_SIGRETURN2 0x07ad
> +#define THUMB2_EABI_SYSCALL 0xdf00
Thanks,
Pedro Alves